vanilla bug?

From dothrow.c:

148. if ((long)multishot > obj->quan) multishot = (int)obj->quan;
149. multishot = rnd(multishot);

Shouldn't these two lines be reversed? With them this way round, being
able to multishot 4 daggers but only carrying 2 reduces your chance of
throwing 2.

Phil

"Philip Potter" <pgp.RemoveThis@doc.ic.ac.uk> wrote in message
news:flbu73$mlj$2@aioe.org...
> From dothrow.c:
>
> 148. if ((long)multishot > obj->quan) multishot = (int)obj->quan;
> 149. multishot = rnd(multishot);
>
> Shouldn't these two lines be reversed? With them this way round, being
> able to multishot 4 daggers but only carrying 2 reduces your chance of
> throwing 2.

substituting values for clarity:

<current code>
if( 4>2 ) multishot = 2 /* cap chances */
multishot = rnd(2)
Result: Player throws only one dagger 2 times out of 4, if only two daggers
in inventory.

<proposed>
multishot = rnd(4)
if( multishot > 2) multishot = 2 /* cap daggers */
Result: Player throws only one dagger 1 time out of 4, reguardless of
inventory.

I agree, the proposed change makes more sense.

--
AngleWyrm,killed by a gnome lord in the Gnomish Mines on level 5
Wiz-Elf-Mal-Cha Score: 1055