Are "they" planning on fixing the Orcish Mines stair issue?

enurmi wrote:
> Erik Piper wrote:
> > Joshua Rodman wrote:

[staircase behavior -- the good, the bad, and the bugly]

> Speaking about strange phenomena and their possible buginess, has
> anyone (else) noticed potions of magic behaving strangely? I'm not at
> all sure about this, and I can't use wizard mode to check, but it seems
> that your maximum mp increases only when you are NOT in full mp. I
> think I have quaffed the potion twice while being in full mp and
> nothing has happened. Then I quaffed one just while ago while having
> (max-1) mp, and gained one or two points to max mp. If this is how it
> always works, I think it's a bit unintuitive. Is this a bug or feature
> or have I got it all wrong? I'm playing b26 with travel patch.

Here's what I see... (Nearly all comments below mine.)

case POT_MAGIC:
// "if we're drinking a potion of magic, then do this:"
mpr( "You feel magical!" );
// print this message -ep
new_value = 5 + random2avg(19, 2);
// set the variable called new_value to 5 + 2 random numbers
from 0 to 19 (I think), that is, 3 + 2d20 (I think).

// increase intrinsic MP points
if (you.magic_points + new_value > you.max_magic_points)
// If adding new_value to your current MP would take it over
your max...
{
new_value = (you.max_magic_points - you.magic_points)
// ...then set new_value equal to max MP minus current MP
(that is, just enough to put you at your current max)...

+ (you.magic_points + new_value - you.max_magic_points)
/ 4 + 1;
// ...plus the following: (current MP + new_value's
value from BEFORE the current operation - max MP) / 4 + 1.

// this step is the only one where current MP makes a
difference, and it's effectively being ADDED to new_value.
}

inc_mp( new_value, true );
// add new_value to current MP, and (since the second parameter
is set to true) if this puts you over max, raise the max.
break;

HOWEVER. Keep in mind, or be informed if you didn't know this before,
that high max MP values are squeezed downwards, and thus multiple
values will sometimes resolve to the same final result. That is, to
make up some fake numbers (too lazy to give a correct example), two
PCs, one with 48 MP behind the scenes and ones with 47 MP behind the
scenes, may both have a final MP of 44. Thus your MP gain from the
potion of magic may have been swallowed up by that.

e.